Skip to content

feat: add SMS verification code flow#113

Draft
Zetazzz wants to merge 2 commits into
mainfrom
feat/send-sms-verification-code-flow
Draft

feat: add SMS verification code flow#113
Zetazzz wants to merge 2 commits into
mainfrom
feat/send-sms-verification-code-flow

Conversation

@Zetazzz

@Zetazzz Zetazzz commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • add the generated send-sms job function and typed provider abstraction
  • implement DevSms delivery through /api/sms/send/twilio
  • normalize and validate phone numbers before rendering verification-code messages
  • support typed dry-run execution without calling a provider
  • add local Docker, Skaffold, and Kubernetes wiring for DevSms
  • keep the toolkit FnGenerator byte-identical with the repository generator for recursive support files and stable auto-assigned ports
  • keep provider failure messages free of response bodies that may echo OTPs or recipients

Validation

  • pnpm install --frozen-lockfile
  • pnpm test:unit -- --runInBand (8 suites; 43 passed, 6 todo)
  • pnpm --filter @constructive-io/fn-generator test (3 passed)
  • pnpm --filter @constructive-io/fn-client test (3 passed)
  • pnpm --filter @constructive-io/fn-cli test (7 passed)
  • pnpm build (all 13 buildable workspace projects)
  • git diff --check

Dependency

Depends on constructive-io/constructive#1383 for the typed SMS configuration exported by @constructive-io/graphql-env and @constructive-io/graphql-types.

Until both PRs are merged and their packages are published, constructive-hub#580 pins these exact feature commits and links the local packages for end-to-end validation.

@socket-security

socket-security Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​constructive-io/​graphql-env@​3.15.07310010098100
Addednpm/​libphonenumber-js@​1.13.89410010094100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants